Messages in this thread | | | Date | Sat, 2 Dec 2006 11:30:24 +0000 | From | Alan <> | Subject | Re: PCI: Let PCI_MULTITHREAD_PROBE not be broken |
| |
On Sat, 2 Dec 2006 00:59:44 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote: > @@ -19,7 +19,7 @@ config PCI_MSI > > config PCI_MULTITHREAD_PROBE > bool "PCI Multi-threaded probe (EXPERIMENTAL)" > - depends on PCI && EXPERIMENTAL && BROKEN > + depends on PCI && EXPERIMENTAL > help
NAK.
It is broken as it breaks init time ordering relied upon by many drivers for same probing and it breaks existing drive assumptions that the probe is single threaded and therefore unlocked.
At the very least it needs
&& !IDE && !WATCHDOG && !ATA
and probably far more.
This should not be enabled or even in the upstream tree until the ordering problem is fixed and the submitter has done a review and fix of all the locking.
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |