lkml.org 
[lkml]   [2006]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT
On Tue, Nov 28, 2006 at 04:45:38PM -0800, Andrew Morton wrote:
> On Tue, 28 Nov 2006 14:08:40 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > NTFS (=m) uses hweight32(), but that function is only linked
> > into the kernel image if it is used inside the kernel image,
> > not in loadable modules. Let modules force HWEIGHT to be
> > built into the kernel image. Otherwise build fails:
> >
> > Building modules, stage 2.
> > MODPOST 94 modules
> > WARNING: "hweight32" [fs/ntfs/ntfs.ko] undefined!
> >
> > Yes, I'd certainly prefer for this to be more automated rather than
> > forced by each module that needs it.
>
> Perhaps we should just put it in lib-y and remove CONFIG_GENERIC_HWEIGHT.
>...

This will obviously not help in this case...

EXPORT_SYMBOL() in a lib-* is always a bug.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-02 18:01    [from the cache]
©2003-2011 Jasper Spaans