Messages in this thread Patch in this message | | | Date | Tue, 19 Dec 2006 17:42:48 +0900 | From | Akinobu Mita <> | Subject | [PATCH] ehca: fix kthread_create() error check |
| |
The return value of kthread_create() should be checked by IS_ERR(). create_comp_task() returns the return value from kthread_create().
Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com> Cc: Christoph Raisch <raisch@de.ibm.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
--- drivers/infiniband/hw/ehca/ehca_irq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Index: 2.6-mm/drivers/infiniband/hw/ehca/ehca_irq.c =================================================================== --- 2.6-mm.orig/drivers/infiniband/hw/ehca/ehca_irq.c +++ 2.6-mm/drivers/infiniband/hw/ehca/ehca_irq.c @@ -670,11 +670,13 @@ static int comp_pool_callback(struct not { unsigned int cpu = (unsigned long)hcpu; struct ehca_cpu_comp_task *cct; + struct task_struct *task; switch (action) { case CPU_UP_PREPARE: ehca_gen_dbg("CPU: %x (CPU_PREPARE)", cpu); - if(!create_comp_task(pool, cpu)) { + task = create_comp_task(pool, cpu); + if (IS_ERR(task)) { ehca_gen_err("Can't create comp_task for cpu: %x", cpu); return NOTIFY_BAD; } @@ -730,7 +732,7 @@ int ehca_create_comp_pool(void) for_each_online_cpu(cpu) { task = create_comp_task(pool, cpu); - if (task) { + if (!IS_ERR(task)) { kthread_bind(task, cpu); wake_up_process(task); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |