lkml.org 
[lkml]   [2006]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Get rid of most of the remaining k*alloc() casts.
    On Tue, 19 Dec 2006, Jan Engelhardt wrote:

    > > Get rid of the remaining obvious pointer casts of all k[cmz]alloc
    > >calls, and do a little whitespace cleanup on the result, based on the
    > >CodingStyle file.
    >
    > >- struct intmem_allocation* alloc =
    > >- (struct intmem_allocation*)kmalloc(sizeof *alloc, GFP_KERNEL);
    > >+ struct intmem_allocation* alloc =
    > >+ kmalloc(sizeof(*alloc), GFP_KERNEL);
    >
    > At the same time, you could make * alloc -> *alloc when it falls on
    > the same line as the kmczalloc cleanup. :)

    i'd actually thought of that but, as with previous patches of mine,
    it's a trade-off -- the more i try to do at once, the more chance
    there is of having the patch rejected for some sort of
    incompatibility.

    as you may have noticed, i try to write scripts to automate a lot of
    this. this last patch definitely needed more manual work than
    previous patches so i was loathe to try to push the envelope -- i
    wanted to concentrate on the superfluous casts this time, and leave
    other issues for future, well-defined patches.

    "bit by bit," that's my motto. well, that and "life is too short to
    drink bad wine."

    rday
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-19 16:51    [W:0.028 / U:360.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site