Messages in this thread | | | Date | Mon, 18 Dec 2006 23:00:32 +0100 | From | "Alessandro Suardi" <> | Subject | Re: 2.6.19 file content corruption on ext3 |
| |
On 12/18/06, Andrei Popa <andrei.popa@i-neo.ro> wrote: > On Mon, 2006-12-18 at 12:41 -0800, Linus Torvalds wrote: > > > > On Mon, 18 Dec 2006, Linus Torvalds wrote: > > > > > > But at the same time, it's interesting that it still happens when we try > > > to re-add the dirty bit. That would tell me that it's one of two cases: > > > > Forget that. There's a third case, which is much more likely: > > > > - Andrew's patch had a ", 1" where it _should_ have had a ", 0". > > > > This should be fairly easy to test: just change every single ", 1" case in > > the patch to ", 0". > > > > The only case that _definitely_ would want ",1" is actually the case that > > already calls page_mkclean() directly: clear_page_dirty_for_io(). So no > > other ", 1" is valid, and that one that needed it already avoided even > > calling the "test_clear_page_dirty()" function, because it did it all by > > hand. > > > > What happens for you in that case? > > > > Linus > > I have file corruption.
No idea whether this can be a data point or not, but here it goes... my P2P box is about to turn 5 days old while running nonstop one or both of aMule 2.1.3 and BitTorrent 4.4.0 on ext3 mounted w/default options on both IDE and USB disks. Zero corruption.
AMD K7-800, 512MB RAM, PREEMPT/UP kernel, 2.6.19-git20 on top of up-to-date FC6.
--alessandro
"...when I get it, I _get_ it"
(Lara Eidemiller) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |