Messages in this thread | | | Subject | Re: [PATCH] Fix sparsemem on Cell | From | Dave Hansen <> | Date | Mon, 18 Dec 2006 13:13:57 -0800 |
| |
On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote: > /* add this memory to iomem resource */ > static struct resource *register_memory_resource(u64 start, u64 size) > { > @@ -273,10 +284,13 @@ > if (ret) > goto error; > } > + atomic_inc(&memory_hotadd_count); > > /* call arch's memory hotadd */ > ret = arch_add_memory(nid, start, size); > > + atomic_dec(&memory_hotadd_count);
I'd be willing to be that this will work just fine. But, I think we can do it without any static state at all, if we just pass a runtime-or-not flag down into the arch_add_memory() call chain.
I'll code that up so we can compare to yours.
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |