lkml.org 
[lkml]   [2006]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kobject.h with HOTPLUG=n
On Mon, Dec 18, 2006 at 09:49:24AM -0800, Randy Dunlap wrote:
> In 2.6.20-rc1-mm1, with HOTPLUG=n, 2 linux/kobject.h inline functions
> need to return <int>. Currently this causes 962 warnings like this:
>
> include/linux/kobject.h: In function 'kobject_uevent':
> include/linux/kobject.h:277: warning: no return statement in function
> returning non-void
> include/linux/kobject.h: In function 'kobject_uevent_env':
> include/linux/kobject.h:281: warning: no return statement in function
> returning non-void
>
> Should these functions return 0 or some error code?
>
> static inline int kobject_uevent(struct kobject *kobj, enum kobject_action
> action) { }
> static inline int kobject_uevent_env(struct kobject *kobj,
> enum kobject_action action,
> char *envp[])
> { }

They should just return 0. Care to make up a quick patch to fix this?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-18 21:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site