Messages in this thread | | | Date | Sat, 16 Dec 2006 23:08:24 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: 2.6.19 file content corruption on ext3 |
| |
On Sat, 16 Dec 2006, Peter Zijlstra wrote: > Moving the cleaning of the page out from under the private_lock opened > up a window where newly attached buffer might still see the page dirty > status and were thus marked (incorrectly) dirty themselves; resulting in > filesystem data corruption.
I'm not going to pretend to understand the buffers issues here: people thought that change was safe originally, and I can't say it's not - it just stood out as a potentially weakening change.
The patch you propose certainly looks like a good way out, if that moved unlock really is a problem: your patch is very well worth trying by those people seeing their corruption problems, let's wait to hear their feedback.
Thanks! Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |