Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [PATCH 1/2] kill_something_info: misc cleanups | Date | Sat, 16 Dec 2006 16:10:01 -0700 |
| |
Oleg Nesterov <oleg@tv-sign.ru> writes:
> On top of > signal-rewrite-kill_something_info-so-it-uses-newer-helpers.patch > > - Factor out sending PIDTYPE_PGID wide signals. > > - Use is_init(p) instead of "p->pid > 1". We don't hash idle threads anymore, > no need to worry about p->pid == 0.
I do not believe is_init is the proper function here. In the presence of multiple pid namespaces the intention is for is_init to catch all of the special handling (except signal behavior) for the init process.
That way when we have multiple processes with pid == 1 we know which one we care about.
> - Use "p != current->group_leader" instead of "p->tgid != current->tgid", > saves one dereference and kills yet another direct pid_t usage.
Makes sense as you have to be a group_leader to be on the task list.
> - Simplify return value calculation for "pid == -1" case, remove "retval" > variable. > > No functional changes.
Looks sane.
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |