lkml.org 
[lkml]   [2006]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: r8169 on n2100 (was Re: r8169 mac address change (was Re: [0/3] 2.6.19-rc2: known regressions))
    On Fri, Dec 15, 2006 at 09:14:35PM +0000, Russell King wrote:

    > > > > Is there a way we can have this done by default on the n2100? I guess
    > > > > that since it's a PCI device, there isn't much hope for that..?
    > > >
    > > > Do you mean an automagically tuned default value based on CONFIG_ARM ?
    > >
    > > No, that wouldn't make sense, that's like making a workaround depend on
    > > arch == i386.
    > >
    > > I'm thinking that we should somehow enable this option on the n2100
    > > built-in r8169 ports by default only. Since the n2100 also has a mini-PCI
    > > slot, and it is in theory possible to put an r8169 on a mini-PCI card,
    > > the workaround probably shouldn't apply to those, so testing for
    > > CONFIG_MACH_N2100 also isn't the right thing to do.
    >
    > There is dev->broken_parity_status ... although exactly what the sematics
    > of that flag actually are seems to be rather vague - there's code which
    > sets it for the Mellanox Tavor device, but it seems to only be exposed
    > via sysfs - no code in drivers/pci seems to take any action based upon
    > this flag being set.

    Sounds good. How about something like the patch below plus the
    corresponding r8169 diff?


    Index: linux-2.6.19/arch/arm/mach-iop32x/n2100.c
    ===================================================================
    --- linux-2.6.19.orig/arch/arm/mach-iop32x/n2100.c
    +++ linux-2.6.19/arch/arm/mach-iop32x/n2100.c
    @@ -123,9 +123,13 @@ static struct hw_pci n2100_pci __initdat

    static int __init n2100_pci_init(void)
    {
    - if (machine_is_n2100())
    + if (machine_is_n2100()) {
    pci_common_init(&n2100_pci);

    + pci_get_bus_and_slot(0, 0x08)->broken_parity_status = 1;
    + pci_get_bus_and_slot(0, 0x10)->broken_parity_status = 1;
    + }
    +
    return 0;
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-12-17 00:13    [W:0.021 / U:0.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site