Messages in this thread | | | Date | Sat, 16 Dec 2006 01:09:06 +0000 | From | Al Viro <> | Subject | Re: Nasty warnings on arm (+ one compile problem -- INIT_WORK related) |
| |
> Plus compile error. It should be some search&replace I should do, but > which one? > > drivers/video/sa1100fb.c:1447:49: macro "INIT_WORK" passed 3 > arguments, but takes just 2 > drivers/video/sa1100fb.c: In function `sa1100fb_init_fbinfo': > drivers/video/sa1100fb.c:1447: error: `INIT_WORK' undeclared (first > use in this function) > drivers/video/sa1100fb.c:1447: error: (Each undeclared identifier is > reported only once > drivers/video/sa1100fb.c:1447: error: for each function it appears > in.) > drivers/video/sa1100fb.c: At top level: > drivers/video/sa1100fb.c:1204: warning: `sa1100fb_task' defined but > not used > make[2]: *** [drivers/video/sa1100fb.o] Error 1 > make[1]: *** [drivers/video] Error 2 > make: *** [drivers] Error 2 > > INIT_WORK(&fbi->task, sa1100fb_task, fbi); > > ... > > /* > * Our LCD controller task (which is called when we blank or unblank) > * via keventd. > */ > static void sa1100fb_task(void *dummy) > { > struct sa1100fb_info *fbi = dummy; > u_int state = xchg(&fbi->task_state, -1); > > set_ctrlr_state(fbi, state); > } > > (Or will I need to play with container_of or something? I guess I did > not pay attetion to workqueue stuff).
... and that's
static void sa1100fb_task(struct work_struct *ucking_fugly) { struct sa1100fb_info *fbi = container_of(ucking_fugly, struct sa1100fb_info, task); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |