lkml.org 
[lkml]   [2006]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros
From
Date
On Wed, 2006-12-13 at 23:45 -0800, Roland Dreier wrote:
> > IOW, do ; while(0) / do { } while (0) is not a proper way to do a macro
> > that imitates a function returning void.
> >
> > Objections?
>
> None from me, although the ternary ? : is a pretty odd way to write
>
> if (blah)
> do_this_void_function();
> else
> do_that_void_function();
>
> so I'm in favor of that half of the patch anyway. It's my fault for
> not noticing that part of the patch in the first place.
>
> Changing the non-void ? : constructions is just churn, but there's no
> sense changing it again now that the patch is merged.

The rest of it was just for consistency sake.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-14 16:35    [W:0.394 / U:1.492 seconds]
©2003-2014 Jasper Spaans. Advertise on this site