lkml.org 
[lkml]   [2006]   [Dec]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 13 Dec 2006 12:12:04 -0800 (PST)
FromLinus Torvalds <>
SubjectRe: [GIT PATCH] more Driver core patches for 2.6.19

On Wed, 13 Dec 2006, Greg KH wrote:
>
> 	- userspace io driver interface added.  This allows the ability
> 	  to write userspace drivers for some types of hardware much
> 	  easier than before, going through a simple interface to get
> 	  accesses to irqs and memory regions.  A small kernel portion
> 	  is still needed to handle the irq properly, but that is it.

Ok, what kind of ass-hat idiotic thing is this?

	irqreturn_t uio_irq_handler(int irq, void *dev_id)
	{
	        return IRQ_HANDLED;
	}
exactly what is the point here? No way will I pull this kind of crap. You 
just seem to have guaranteed a dead machine if the irq is level-triggered, 
since it will keep on happening forever.

Please remove.

YOU CANNOT DO IRQ'S BY LETTING USER SPACE SORT IT OUT!

It's really that easy. The irq handler has to be _entirely_ in kernel 
space. No user-space ass-hattery here.

And I don't care one whit if it happens to work on parport with an old 
legacy ISA interrupt that is edge-triggered. That's not even the 
interesting case. Never will be.

NAK NAK NAK NAK.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-13 21:15    [from the cache]
©2003-2008