Messages in this thread | | | Date | Wed, 13 Dec 2006 14:53:25 +0000 | From | Alan <> | Subject | Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver |
| |
> >>+static int tc86c001_busproc(ide_drive_t *drive, int state) > >>+{ > > > Waste of space having a busproc routine. The maintainer removed all the > > usable hotplug support from old IDE so this might as well be dropped. > > Don't know what you mean, ioctl is still there...
You can turn the bus on and off but there is no ability to actually swap drives except in RHEL4 and 2.4.x-ac kernels. Hence "waste of space"
> > "Close but no cookie": please fix the PCI quirk to match the current -mm > > behaviour with the ATA resource tree. Otherwise - nice driver. > > Ugh, I should've expected some backstab from -mm tree...
If it is native only then there are no problems with the quirk
Acked-by: Alan Cox <alan@redhat.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |