lkml.org 
[lkml]   [2006]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pipe: Don't oops when pipe filesystem isn't mounted
Linus Torvalds wrote:
>
> On Mon, 11 Dec 2006, Chuck Ebbert wrote:
>> Prevent oops when an app tries to create a pipe while pipefs
>> is not mounted.
>
> Have you actually seen this, or is this just from looking at code?
>
> Quite frankly, if "pipe_mnt" is ever NULL, we're dead for lots of other
> reasons.
>
> In fact, pipe_mnt can't be NULL. The way it is initialized is:
>
> pipe_mnt = kern_mount(&pipe_fs_type);
>
> and pipe_mnt doesn't even return NULL - it returns an error pointer, so if
> "kern_mount()" were to have failed, pipe_mnt will be some random invalid
> pointer that could only be tested with IS_ERR(), not by comparing against
> NULL.

http://marc.theaimsgroup.com/?t=116510390600001&r=1&w=2
/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-12 13:25    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site