lkml.org 
[lkml]   [2006]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 2.6.19 5/6] add "add" element in /sys/class/misc/netconsole
On Tue, Dec 12, 2006 at 03:37:20PM +0900, Keiichi KII wrote:
> From: Keiichi KII <k-keiichi@bx.jp.nec.com>
>
> This patch contains the following changes.
>
> To add port dynamically, create "add" element in /sys/class/misc/netconsole.
>
> ex)
> 1. echo "eth0" > /sys/clas/misc/netconsole/add
> then the port is added with the default settings.

What are the default settings for target IP address?

> 2. echo "@/eth0,@192.168.0.1/" > /sys/class/misc/netconsole/add
> then the port is added with the settings sending kernel messages
> to 192.168.0.1 using eth0 device.
>
> -+- /sys/class/misc/
> |-+- netconsole/
> |--- add [-w-------] If you write parameter(network interface name
> | or one config parameter of netconsole), The
> | port related its config is added
> |--- port1/
> |--- port2/
> ...
>
> Signed-off-by: Keiichi KII <k-keiichi@bx.jp.nec.com>
> ---
> --- linux-2.6.19/drivers/net/netconsole.c 2006-12-06 14:37:26.874827500 +0900
> +++ enhanced-netconsole/drivers/net/netconsole.c.add 2006-12-06
> 13:33:05.661516750 +0900
> @@ -321,6 +321,50 @@ static struct miscdevice netcon_miscdev
> .name = "netconsole",
> };
>
> +static ssize_t set_netconmisc_add(struct class_device *cdev, const char *buf,
> + size_t count)
> +{
> + char *target;
> + char *target_param;
> +
> + target_param = (char*)kmalloc(count+1, GFP_ATOMIC);

Unnecessary cast.

> + for(i=0; i < ARRAY_SIZE(netcon_misc_attr); i++) {
> + class_device_create_file(netcon_miscdev.class,
> + netcon_misc_attr[i]);
> + }
> +

This chunk looks like it goes in an earlier patch.

--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-12 20:39    [W:0.425 / U:1.140 seconds]
©2003-2014 Jasper Spaans. Advertise on this site