lkml.org 
[lkml]   [2006]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pipe: Don't oops when pipe filesystem isn't mounted


On Mon, 11 Dec 2006, Andrew Morton wrote:
>
> Looks like this might break pcmcia which for some reason does firmware
> requesting at fs_initcall level (drivers/pcmcia/ds.c).

Ok, that's just strange.

I think it's fine to do init_pcmcia_bus early to make sure that the PCMCIA
bus interface is there by the time the driver init stuff happens, but I
really don't see the point of that firmware load to be there. And all that
MATCH_FAKE_CIS stuff is about the _devices_, not the PCMCIA bus, so that
whole thing looks pretty silly. It should be done by the device
registration (which is obviously device_initcall), not by some bus layer.

Hopefully Dominik can fix whatever up (if it even needs it)

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.053 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site