Messages in this thread | | | Subject | RE: [PATCH] i386 add idle notifier (take 2) | Date | Mon, 11 Dec 2006 14:40:43 -0800 | From | "Pallipadi, Venkatesh" <> |
| |
Stephane,
This patch has the same race as in 64 bit patch, that was fixed here http://www.ussg.iu.edu/hypermail/linux/kernel/0611.3/1264.html
With that race, idle callbacks does not work correctly. Even on a totally idle system, I can see exit_idle called before enter_idle once every few seconds. Can you update this patch with similar changes as in 64 bit part in the above patch.
Thanks, Venki
>-----Original Message----- >From: linux-kernel-owner@vger.kernel.org >[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of >Stephane Eranian >Sent: Wednesday, November 29, 2006 8:41 AM >To: linux-kernel@vger.kernel.org >Cc: akpm@osdl.org; ak@suse.de; Stephane Eranian >Subject: Re: [PATCH] i386 add idle notifier (take 2) > >Hello, > >[This is the second take due to stray '}' in the patch. Sorry >about that] > >Here is a patch that adds an idle notifier to the i386 tree. >The idle notifier functionalities and implementation are >identical to the x86_64 idle notifier. We use the idle notifier >in the context of perfmon. > >The patch is against Andi Kleen's x86_64-2.6.19-rc6-061128-1.bz2 >kernel. It may apply to other kernels but it needs some updates >to poll_idle() and default_idle() to work correctly. > >changelog: > - add an idle notifier mechanism to i386 tree > >signed-off-by: stephane eranian <eranain@hpl.hp.com> > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |