Messages in this thread | | | Date | Mon, 11 Dec 2006 11:11:07 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: 2.6.19-git13: uts banner changes break SLES9 (at least) |
| |
On Mon, 11 Dec 2006, Olaf Hering wrote: > > arch/powerpc/boot/wrapper:156: version=`${CROSS}strings "$kernel" | grep '^Linux version [-0-9.]' | \
This is also obviously broken (and really sad), but actually ends up being better than what get_kernel_version apparently does, by at least adding the requirement that the string "Linux version" be slightly more correct.
However, it's also TOTALLY BROKEN.
For example, if the Linux version string happens to be preceded by a byte that is a valid ASCII character, the grep will fail miserably. So that PoS is actually going to fail for various random kernels too, and depends intimately on just what variable _happened_ to be linked just before the version string.
The fact is, doing strings on the kernel is just not a viable alternative to real versioning.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |