Messages in this thread | | | Subject | Re: Mark bitrevX() functions as const | From | Bernd Petrovitsch <> | Date | Mon, 11 Dec 2006 18:51:50 +0100 |
| |
On Mon, 2006-12-11 at 18:35 +0100, Jan Engelhardt wrote: [...] > I can just second this. What should be marked const is [1]the things > pointed to, not [2]the local copy of a function argument. > > This[2] is what I believe almost every other software project does,
Yes, also for the reason to educate people to actually use "const" as much as possible - if only to make it for humans clear what may change somewhere and what not.
> though they often fail at [1]. Or have you seen Glibc trying to pull a > int strtoul(const char *const nptr, char **const endptr, const int > base)? It just makes the prototypes and headers longer without having
glibc functions like strtoul() are an extremely bad example for this because there are standards out there which the define the function signature - so it is often not really the choice of some glibc developer/maintainer/project lead. Or you have very old implementations like e.g. the RPC/XDR library which simply ignore the "const" keyword.
> too much benefit. And maybe the code author may even want to reuse the > args directly as walking pointers or countdown integers, for example.
And that is the other problem of such functions and C as such: One wants the "const char *" in the argument list (if possible) since it allows to pass "const char *" and "char *". The return value should similarly be "char *" because then you can use it in the above mentioned way for "const char *" and "char *". Alas that gives you a chance to "cast" "const char *" to "char *" and not even trigger a compiler warning (as opposed a real type cast). Of course this can be handled/fixed by review but it takes people to actually do this. The only sane solution is to get out the same const-ness as passed in - but this is syntactically not possible in plain simple C.
And the above paragraph is not arguing to remove the keyword "const".
Bernd -- Firmix Software GmbH http://www.firmix.at/ mobil: +43 664 4416156 fax: +43 1 7890849-55 Embedded Linux Development and Services
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |