Messages in this thread | | | Date | Mon, 11 Dec 2006 11:27:28 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH -mm] sata_nv: add suspend/resume support |
| |
Robert Hancock wrote: > +static void nv_remove_one (struct pci_dev *pdev) > +{ > + struct ata_host *host = dev_get_drvdata(&pdev->dev); > + struct nv_host_priv *hpriv = host->private_data; > + > + kfree(hpriv); > + ata_pci_remove_one(pdev); > +}
It is unwise to free the struct before the ports are even detached.
Otherwise, seems ok, but I would like to see some more positive user reports (both ADMA and not) before pushing upstream.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |