Messages in this thread | | | Date | Mon, 11 Dec 2006 08:23:02 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] lockdep: fix possible races while disabling lock-debugging |
| |
* Jarek Poplawski <jarkao2@o2.pl> wrote:
> > @@ -567,12 +601,10 @@ static noinline int print_circular_bug_t > > if (debug_locks_silent) > > return 0; > > > > - /* hash_lock unlocked by the header */ > > - __raw_spin_lock(&hash_lock); > > this.class = check_source->class; > > if (!save_trace(&this.trace)) > > return 0; > > - __raw_spin_unlock(&hash_lock); > > + > > IMHO lock is needed here for save_trace.
indeed. I'll do a fix for this.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |