Messages in this thread | | | Date | Thu, 30 Nov 2006 23:08:12 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2.6.19] kobject: kobject_uevent() returns manageable value |
| |
On Thu, 30 Nov 2006 16:58:47 -0400 Mauricio Lin <mauricio.lin@indt.org.br> wrote:
> Since kobject_uevent() function does not return an integer value to > indicate if its operation was completed with success or not, it is > worth changing it in order to report a proper status (success or > error) instead of returning void. > > Keep kobject_uevent() returning the status as integer provide a easier > way for detecting possible failure in the function. Using void > returning style may take people to waste more time to figure out if > the "send to" or "receive from" an event is a bug in the kernel or > user space. Furthermore, the current way to detect where the error is > taking place in the kobject_uevent() requires additional inclusion of > printk() in each "if" condition that can lead to failure.
Admirable idea, but we have large changes pending against that code and none of this patch applies.
A patch against Greg's driver tree, or against latest -mm would suit, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |