![]() | |||||||||||||
Messages in this thread |
On Wed, Nov 08, 2006 at 11:00:59PM -0800, David Miller wrote: > From: "Chen, Kenneth W" <kenneth.w.chen@intel.com> > Date: Wed, 8 Nov 2006 18:02:06 -0800 > > > The generic version of csum_ipv6_magic has the len argument declared as > > __u16, while most arch dependent version declare it as __u32. After > > looking at the call site of this function, I come up to a conclusion > > that __u32 is a better match with the actual usage. > > > > Hence, patch to change argument type for greater consistency. > > > > Signed-off-by: Ken Chen <kenneth.w.chen@intel.com> > > Architecture implementations such as the ones for m32r and parisc have > the same problem, so "for consistency" please fix them up as well. > > Thanks a lot. Please, hold. One of the patches in my queue gets sanitized prototypes for all that stuff and it'll conflict like crazy. I haven't touch that argument yet; if there's an agreement as to what should we switch to, I'll do that. So... does everyone agree that u32 is the way to go? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-11-09 07:27 [from the cache] ©2003-2008 | |||||||||||||