lkml.org 
[lkml]   [2006]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.19-rc5: known regressions
    On Wed, Nov 08 2006, Adrian Bunk wrote:
    > Subject : unable to rip cd
    > References : http://lkml.org/lkml/2006/10/13/100
    > Submitter : Alex Romosan <romosan@sycorax.lbl.gov>
    > Status : unknown

    Alex, was/is this repeatable? If so I'd like you to repeat with this
    debug patch applied, I cannot reproduce it locally.

    diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
    index bddfebd..ad03e19 100644
    --- a/drivers/ide/ide-cd.c
    +++ b/drivers/ide/ide-cd.c
    @@ -1726,8 +1726,10 @@ static ide_startstop_t cdrom_newpc_intr(
    /*
    * write to drive
    */
    - if (cdrom_write_check_ireason(drive, len, ireason))
    + if (cdrom_write_check_ireason(drive, len, ireason)) {
    + blk_dump_rq_flags(rq, "cdrom_newpc");
    return ide_stopped;
    + }

    xferfunc = HWIF(drive)->atapi_output_bytes;
    } else {
    @@ -1859,8 +1861,10 @@ static ide_startstop_t cdrom_write_intr(
    }

    /* Check that the drive is expecting to do the same thing we are. */
    - if (cdrom_write_check_ireason(drive, len, ireason))
    + if (cdrom_write_check_ireason(drive, len, ireason)) {
    + blk_dump_rq_flags(rq, "cdrom_pc");
    return ide_stopped;
    + }

    sectors_to_transfer = len / SECTOR_SIZE;

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-08 10:35    [W:0.021 / U:2.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site