lkml.org 
[lkml]   [2006]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/33] usb: writing_usb_driver free urb cleanup
    Date
    Hello,

    Allright. As Greg KH suggested I split this big patch into smaller ones to
    make the changes easier to review. Having no better idea how to split that I
    split it on a 'patch per file' basis. All those patches clean redundant 'if' before
    usb_unlink/free/kill_urb():

    if (urb)
    usb_free_urb(urb); /* unlink / free / kill */

    I decided not to touch bigger 'if's like

    if (urb) {
    usb_kill_urb(urb);
    usb_free_urb(urb);
    urb = NULL;
    }

    as that would be probably too intrusive. One of patches also fixes
    drivers/usb/misc/auerswald.c memleak I found when digging the code. All those
    patches are against 2.6.19-rc4.
    --
    Regards,

    Mariusz Kozlowski

    Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

    --- linux-2.6.19-rc4-orig/Documentation/DocBook/writing_usb_driver.tmpl 2006-11-06 17:06:39.000000000 +0100
    +++ linux-2.6.19-rc4/Documentation/DocBook/writing_usb_driver.tmpl 2006-11-06 19:50:58.000000000 +0100
    @@ -345,8 +345,7 @@ static inline void skel_delete (struct u
    usb_buffer_free (dev->udev, dev->bulk_out_size,
    dev->bulk_out_buffer,
    dev->write_urb->transfer_dma);
    - if (dev->write_urb != NULL)
    - usb_free_urb (dev->write_urb);
    + usb_free_urb (dev->write_urb);
    kfree (dev);
    }
    </programlisting>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-08 15:37    [W:0.024 / U:29.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site