Messages in this thread |  | | | Date | Tue, 07 Nov 2006 14:58:09 -0800 (PST) | | Subject | Re: tg3_read_partno(): possible array overrun | | From | David Miller <> |
| |
From: "Michael Chan" <mchan@broadcom.com> Date: Mon, 06 Nov 2006 12:07:31 -0800
> On Mon, 2006-11-06 at 10:45 +0100, Adrian Bunk wrote: > > The Coverity checker noted the following in drivers/net/tg3.c: > > > > <-- snip --> > > > > The problem is that vpd_data[i + 2] could be vpd_data[255 + 2]. > > Thanks. This should fix it: > > [TG3]: Fix array overrun in tg3_read_partno(). > > Use proper upper limits for the loops and check for all error > conditions. > > The problem was noticed by Adrian Bunk. > > Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |