lkml.org 
[lkml]   [2006]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: realtime-preempt patch-2.6.18-rt7 oops

    * Mike Galbraith <efault@gmx.de> wrote:

    > I just reproduced it running glibc make check. I had just enabled
    > kprobes and recompiled with the stock SuSE-10.1 compiler while waiting
    > for you to send me your .config (nevermind that request) so I could
    > try to reproduce it here.

    hm, so kprobe_flush_task() is likely PREEMPT_RT-unsafe.

    could you try the patch below, does it help? (a quick review seems to
    suggest that all codepaths protected by kretprobe_lock are atomic)

    Ingo

    Index: linux/kernel/kprobes.c
    ===================================================================
    --- linux.orig/kernel/kprobes.c
    +++ linux/kernel/kprobes.c
    @@ -50,7 +50,7 @@ static struct hlist_head kretprobe_inst_
    static atomic_t kprobe_count;

    DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
    -DEFINE_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
    +DEFINE_RAW_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
    static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;

    static struct notifier_block kprobe_page_fault_nb = {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-06 10:41    [W:0.022 / U:29.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site