![]() | |||||||||||||
Messages in this thread |
Florin Malita wrote: > create_proc_entry() can fail and return NULL in setup_proc_entry(), the > result must be checked before dereferencing. (Coverity ID 1443) > > init_wifidev() & setup_proc_entry() can also fail in _init_airo_card(). > > This adds the checks & cleanup code and removes some whitespace. > > Signed-off-by: Florin Malita <fmalita@gmail.com> NAK: create_proc_entry() is complicated. You are correct it can fail -- but to add to the confusion, when CONFIG_PROC_FS is disabled, the wrapper will also return NULL -- which is NOT a failure case. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-11-06 08:01 [from the cache] ©2003-2008 | |||||||||||||