Messages in this thread | | | Date | Mon, 6 Nov 2006 11:01:52 -0800 | From | Andrew Morton <> | Subject | Re: [patch] Regression in 2.6.19-rc microcode driver |
| |
On Mon, 06 Nov 2006 15:15:38 +0100 Arjan van de Ven <arjan@linux.intel.com> wrote:
> Hi, > > if the microcode driver is built in (rather than module) there are some, > ehm, interesting effects happening due to the new "call out to > userspace" behavior that is introduced.. and which runs too early. The > result is a boot hang; which is really nasty. > > The patch below is a minimally safe patch to fix this regression for > 2.6.19 by just not requesting actual microcode updates during early > boot. (That is a good idea in general anyway) > > The "real" fix is a lot more complex given the entire cpu hotplug > scenario (during cpu hotplug you normally need to load the microcode as > well); but the interactions for that are just really messy at this > point; this fix at least makes it work and avoids a full detangle of > hotplug. > > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> > > --- linux-2.6.18/arch/i386/kernel/microcode.c.org 2006-11-06 14:50:37.000000000 +0100 > +++ linux-2.6.18/arch/i386/kernel/microcode.c 2006-11-06 14:52:30.000000000 +0100 > @@ -577,7 +577,7 @@ static void microcode_init_cpu(int cpu) > set_cpus_allowed(current, cpumask_of_cpu(cpu)); > mutex_lock(µcode_mutex); > collect_cpu_info(cpu); > - if (uci->valid) > + if (uci->valid && system_state==SYSTEM_RUNNING) > cpu_request_microcode(cpu); > mutex_unlock(µcode_mutex); > set_cpus_allowed(current, old);
Can we fix this by switching to late_initcall() or something like that? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |