lkml.org 
[lkml]   [2006]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] Regression in 2.6.19-rc microcode driver
    Andrew Morton wrote:
    >> --- linux-2.6.18/arch/i386/kernel/microcode.c.org 2006-11-06 14:50:37.000000000 +0100
    >> +++ linux-2.6.18/arch/i386/kernel/microcode.c 2006-11-06 14:52:30.000000000 +0100
    >> @@ -577,7 +577,7 @@ static void microcode_init_cpu(int cpu)
    >> set_cpus_allowed(current, cpumask_of_cpu(cpu));
    >> mutex_lock(&microcode_mutex);
    >> collect_cpu_info(cpu);
    >> - if (uci->valid)
    >> + if (uci->valid && system_state==SYSTEM_RUNNING)
    >> cpu_request_microcode(cpu);
    >> mutex_unlock(&microcode_mutex);
    >> set_cpus_allowed(current, old);
    >
    > Can we fix this by switching to late_initcall() or something like that?

    I will try but it then still runs before userspace (esp "init") is
    alive so I'm not convinced it'll do the right thing
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-06 20:05    [W:0.022 / U:0.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site