![]() | ||||||||||
Messages in this thread |
Paul Jackson wrote: > Balbir wrote: >> This should be kmalloc(nbytes), an echo ".." has a "\n" associated >> with it. > > But a: > write(1, "..", 2); > does not have a trialing newline. Yes, true. > > If some consumer of this kernel buffer copy of what the > user wrote cannot handle the possible trailing whitespace, > they will have to chomp (Perl phrase) it off. You can't > just whack one byte blindly. > Yes, agreed. > At least for the kernel/cpuset.c code, from whence this > came, the consumers of this kernel buffer copy are such > routines as simple_strtoul() and cpulist_parse(), both > of which cope with trailing newlines. > The problem I have is that match_token() that's used by the resource group's infrastructure cannot deal with "\n". I think the code needs in res_groups needs to get smarter like the code in simple_strtoul() -- Thanks for the feedback, Balbir Singh, Linux Technology Center, IBM Software Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2006-11-06 05:13 [from the cache] ©2003-2008 | ||||||||||