lkml.org 
[lkml]   [2006]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] sunrpc: add missing spin_unlock
    From
    Date
    On Sun, 2006-10-29 at 22:37 +0900, Akinobu Mita wrote:
    > auth_domain_put() forgot to unlock acquired spinlock.
    >
    > Cc: Olaf Kirch <okir@monad.swb.de>
    > Cc: Andy Adamson <andros@citi.umich.edu>
    > Cc: J. Bruce Fields <bfields@citi.umich.edu>
    > Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
    > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

    Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

    I just found this too while trying to get .19-rc4-git up and running on
    a machine here - took me a few hours.

    It made my kernel decidedly unhappy :-(

    Andrew, could you push this and:
    http://lkml.org/lkml/2006/11/3/109
    into .19 still? - those patches are needed to make todays git happy on
    my machine.

    > Index: work-fault-inject/net/sunrpc/svcauth.c
    > ===================================================================
    > --- work-fault-inject.orig/net/sunrpc/svcauth.c
    > +++ work-fault-inject/net/sunrpc/svcauth.c
    > @@ -126,6 +126,7 @@ void auth_domain_put(struct auth_domain
    > if (atomic_dec_and_lock(&dom->ref.refcount, &auth_domain_lock)) {
    > hlist_del(&dom->hash);
    > dom->flavour->domain_release(dom);
    > + spin_unlock(&auth_domain_lock);
    > }
    > }


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-05 17:41    [W:0.073 / U:1.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site