lkml.org 
[lkml]   [2006]   [Nov]   [5]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] Add Legacy IDE mode support for SB600 SATA
    FromAlan Cox <>
    DateSun, 05 Nov 2006 15:08:45 +0000
    Ar Sul, 2006-11-05 am 21:38 +0800, ysgrifennodd Conke Hu:
    >   Consider that the behavior itself of using the new motherboard, SB600,
    > means a lot of change, so even if the user still use IDE driver, he also
    > a need verification process.
    
    It depends on the person but yes I had considered that.
    
    > > This is not neccessarily misguided. They may want to do this.
    >   But the SB600 SATA controller is really an AHCI controller. And that
    > will lose high performance (and cannot use NCQ).
    
    Maybe they want stability and certainty first.
    
    >   OK, I am rewriting the patch based on the following considerations:
    >   1. move these code to ahci driver, and add new code to PATA driver.
    >   2. add new options to kernel configuration, and users can choose IDE
    > driver or AHCI driver to support SB600 SATA when it is in IDE mode.
    
    That seems fine to me. I would have thought putting the code you have
    into the quirks.c file as you proposed was the better way to do this,
    but with the addition of the 
    
    #if defined (CONFIG_ATA_AHCI) || defined(CONFIG_ATA_AHCI_MODULE)
    #endif
    
    around it, was sufficient ?
    
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2006-11-05 16:07    [from the cache]
    ©2003-2008