lkml.org 
[lkml]   [2006]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] UBI: take 2
From
Date
On Thu, 2006-11-30 at 17:06 -0800, Andrew Morton wrote:
> >
> > The source code is available at the UBI GIT tree:
> > git://git.infradead.org/ubi-2.6.git
>
> Got that, thanks. It needs a bit of help:
>
> --- a/drivers/mtd/ubi/cdev.c~git-ubi-fix
> +++ a/drivers/mtd/ubi/cdev.c
> @@ -1185,7 +1185,7 @@ static ssize_t vol_cdev_direct_write(str
> len, vol_id, lnum, off);
>
> err = ubi_eba_write_leb(ubi, vol_id, lnum, tbuf, off, len,
> - UBI_DATA_UNKNOWN, &written, 0, NULL);
> + UBI_DATA_UNKNOWN, &written, NULL);
> if (unlikely(err)) {
> count -= written;
> *offp += written;
> _

Nice catch. Odd that gcc doesn't throw a warning on my system with it
being like that.

CC drivers/mtd/ubi/badeb.o
CC drivers/mtd/ubi/upd.o
CC drivers/mtd/ubi/sysfs.o
CC drivers/mtd/ubi/cdev.o
CC drivers/mtd/ubi/uif.o
CC drivers/mtd/ubi/vtbl.o
CC drivers/mtd/ubi/volmgmt.o
CC drivers/mtd/ubi/eba.o

Anyway, we'll get the patch into the tree ASAP.

josh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-01 05:25    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site