Messages in this thread | | | Date | Thu, 30 Nov 2006 10:45:56 -0800 | From | Andy Isaacson <> | Subject | Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static |
| |
On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote: > This patch makes the needlessly global mtdpart_setup() static. > > @@ -346,7 +346,7 @@ > * > * This function needs to be visible for bootloaders. > */ > -int mtdpart_setup(char *s) > +static int mtdpart_setup(char *s) > { > cmdline = s; > return 1;
Jarkko,
You're recorded as submitting the original patch to make this non-static: http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/cmdlinepart.c@1.11?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c
Is this change correct?
If so, it should also delete the "needs to be visible" comment.
-andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |