Messages in this thread | | | Date | Wed, 29 Nov 2006 08:40:09 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT |
| |
On Tue, Nov 28, 2006 at 02:08:40PM -0800, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > NTFS (=m) uses hweight32(), but that function is only linked > into the kernel image if it is used inside the kernel image, > not in loadable modules. Let modules force HWEIGHT to be > built into the kernel image. Otherwise build fails: > > Building modules, stage 2. > MODPOST 94 modules > WARNING: "hweight32" [fs/ntfs/ntfs.ko] undefined! > > Yes, I'd certainly prefer for this to be more automated rather than > forced by each module that needs it.
Please just make it builtin-in always and remove it from lib-y. Bonus points for killing of the lib-y braindamage entirely.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |