lkml.org 
[lkml]   [2006]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] genapic: always use physical delivery mode on > 8 CPUs
    On Tue, Nov 28, 2006 at 07:33:46AM +0100, Ingo Molnar wrote:
    > - if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster)
    > + if (max_apic < 8)

    Patch mostly looks good. Instead of checking for max_apic, can we use
    cpus_weight(cpu_possible_map) <= 8

    This will help where initially system booted with <= 8 cpus and hotplug
    potentially can bringup more cpus later..

    thanks,
    suresh

    > genapic = &apic_flat;
    > else
    > - genapic = &apic_cluster;
    > +force_physflat:
    > + genapic = &apic_physflat;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-28 20:41    [W:0.022 / U:29.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site