lkml.org 
[lkml]   [2006]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[Patch 5/7] driver core: Change function call order in device_bind_driver().
    From: Cornelia Huck <cornelia.huck@de.ibm.com>

    Change function call order in device_bind_driver().

    If we create symlinks (which might fail) before adding the device to the list
    we don't have to clean up afterwards (which we didn't).

    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

    ---
    drivers/base/dd.c | 8 ++++++--
    1 files changed, 6 insertions(+), 2 deletions(-)

    --- linux-2.6-CH.orig/drivers/base/dd.c
    +++ linux-2.6-CH/drivers/base/dd.c
    @@ -86,8 +86,12 @@ static void driver_sysfs_remove(struct d
    */
    int device_bind_driver(struct device *dev)
    {
    - driver_bound(dev);
    - return driver_sysfs_add(dev);
    + int ret;
    +
    + ret = driver_sysfs_add(dev);
    + if (!ret)
    + driver_bound(dev);
    + return ret;
    }

    struct stupid_thread_structure {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-27 10:37    [W:0.020 / U:61.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site