lkml.org 
[lkml]   [2006]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers
From
Date
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:

> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

If it helps,
Acked-by: Frank Ch. Eigler <fche@redhat.com>


One question:

> [...]
> + /* Markers in modules. */
> + list_for_each_entry(mod, &modules, list) {
> + if (mod->license_gplok)
> + found += marker_set_probe_range(name, format, probe,
> + mod->markers, mod->markers+mod->num_markers);
> + }
> [...]
> +EXPORT_SYMBOL(marker_set_probe);

Are you sure the license_gplok check is necessary here? We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.


- FChE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-28 03:29    [W:0.072 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site