Messages in this thread | | | Subject | Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers | From | (Frank Ch. Eigler) | Date | 27 Nov 2006 21:23:17 -0500 |
| |
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:
> This patch adds the Linux Kernel Markers [...] > Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
If it helps, Acked-by: Frank Ch. Eigler <fche@redhat.com>
One question:
> [...] > + /* Markers in modules. */ > + list_for_each_entry(mod, &modules, list) { > + if (mod->license_gplok) > + found += marker_set_probe_range(name, format, probe, > + mod->markers, mod->markers+mod->num_markers); > + } > [...] > +EXPORT_SYMBOL(marker_set_probe);
Are you sure the license_gplok check is necessary here? We should consider encouraging non-gpl module writers to instrument their code, to give users a slightly better chance of debugging problems.
- FChE - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |