lkml.org 
[lkml]   [2006]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PARISC] Fix incorrent type of flags in <asm/semaphore.h>
    I still think using BUILD_BUG_ON() is unacceptable, especially given how
    vague the error message was.

    Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
    ---
    diff --git a/include/asm-parisc/semaphore.h b/include/asm-parisc/semaphore.h
    index c9ee41c..d45827a 100644
    --- a/include/asm-parisc/semaphore.h
    +++ b/include/asm-parisc/semaphore.h
    @@ -115,7 +115,8 @@ extern __inline__ int down_interruptible
    */
    extern __inline__ int down_trylock(struct semaphore * sem)
    {
    - int flags, count;
    + unsigned long flags;
    + int count;

    spin_lock_irqsave(&sem->sentry, flags);
    count = sem->count - 1;
    @@ -131,7 +132,8 @@ extern __inline__ int down_trylock(struc
    */
    extern __inline__ void up(struct semaphore * sem)
    {
    - int flags;
    + unsigned long flags;
    +
    spin_lock_irqsave(&sem->sentry, flags);
    if (sem->count < 0) {
    __up(sem);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-27 00:59    [W:0.026 / U:30.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site