lkml.org 
[lkml]   [2006]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH]: scsi: in2000 scsi_cmnd convertion
From
Date
On Thu, 2006-11-23 at 13:48 +0100, Henne wrote:
> - volatile Scsi_Cmnd *input_Q; /* commands waiting to be started */
> - volatile Scsi_Cmnd *selecting; /* trying to select this command */
> - volatile Scsi_Cmnd *connected; /* currently connected command */
> - volatile Scsi_Cmnd *disconnected_Q;/* commands waiting for reconnect */
> + volatile struct scsi_cmnd *input_Q;
> + /* commands waiting to be started */
> + volatile struct scsi_cmnd *selecting;
> + /* trying to select this command */
> + volatile struct scsi_cmnd *connected;
> + /* currently connected command */
> + volatile struct scsi_cmnd *disconnected_Q;

This doesn't preserve the indentation of the original.

Plus, I think if you lose the volatile then a lot of pointless casts
like this one:

> - tmp = (Scsi_Cmnd *) hostdata->input_Q;
> + tmp = (struct scsi_cmnd *) hostdata->input_Q;

Can be eliminated entirely (its sole job is to drop the volatile again).

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-25 00:05    [W:0.022 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site