lkml.org 
[lkml]   [2006]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 6pack: fix "&= !" typo
    On Fri, Nov 24, 2006 at 08:21:53PM +0000, Ralf Baechle wrote:
    > On Fri, Nov 24, 2006 at 09:58:16PM +0300, Alexey Dobriyan wrote:
    >
    > > Andreas, is this correct?
    > > ---------------------------------
    > > SIXP_RX_DCD_MASK is 0x18, so the command below will make cmd 0 always.
    > > This is likely wrong.
    > >
    > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    >
    > This one is already merged.
    >
    > It's funny how long this bug survived - it's in the kernel since the 6pack
    > driver was first merged that is 2.1 or 2.2 ...

    One more reason to perform more code reviews helped with automated tools.
    We found this one and the rio's one while discussing with Jean Delvare
    about such bugs, and firing a random grep to illustrate how easy it could
    be to spot bugs similar to Alexey's "&&" instead of "&" ...

    I think that we should at least take a look at all lines in the pre-processed
    code having both '!' and '&' on the same line. There are a lot of them, but
    divided by a sufficient number of volunteers, we might catch a bunch of them.

    BTW, has anyone a good idea on how to make gcc dump the preprocessed files
    for everything it builds ? I mean, just by changing some variables in the
    Makefile.

    > Ralf

    Cheers,
    Willy

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-24 22:27    [W:0.024 / U:1.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site