Messages in this thread Patch in this message | | | Date | Fri, 24 Nov 2006 21:58:16 +0300 | From | Alexey Dobriyan <> | Subject | [PATCH] 6pack: fix "&= !" typo |
| |
Andreas, is this correct? --------------------------------- SIXP_RX_DCD_MASK is 0x18, so the command below will make cmd 0 always. This is likely wrong.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> ---
drivers/net/hamradio/6pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c @@ -914,7 +914,7 @@ static void decode_prio_command(struct s printk(KERN_DEBUG "6pack: protocol violation\n"); else sp->status = 0; - cmd &= !SIXP_RX_DCD_MASK; + cmd &= ~SIXP_RX_DCD_MASK; } sp->status = cmd & SIXP_PRIO_DATA_MASK; } else { /* output watchdog char if idle */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |