lkml.org 
[lkml]   [2006]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 5/5] DebugFS : file/directory removal fix, 2.6.19-rc6
    Fix file and directory removal in debugfs. Add inotify support for file removal.

    The following scenario :
    create dir a
    create dir a/b

    cd a/b (some process goes in cwd a/b)

    rmdir a/b
    rmdir a

    fails due to the fact that "a" appears to be non empty. It is because the "b"
    dentry is not deleted from "a" and still in use. The same problem happens if
    "b" is a file. d_delete is nice enough to know when it needs to unhash and free
    the dentry if nothing else is using it or, if someone is using it, to remove it
    from the hash queues and wait for it to be deleted when it has no users.

    The nice side-effect of this fix is that it calls the file removal
    notification.

    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

    ---BEGIN---
    --- a/fs/debugfs/inode.c
    +++ b/fs/debugfs/inode.c
    @@ -285,6 +285,7 @@ void debugfs_remove(struct dentry *dentr
    mutex_lock(&parent->d_inode->i_mutex);
    if (debugfs_positive(dentry)) {
    if (dentry->d_inode) {
    + dget(dentry);
    if (S_ISDIR(dentry->d_inode->i_mode)) {
    ret = simple_rmdir(parent->d_inode, dentry);
    if (ret)
    @@ -294,6 +295,9 @@ void debugfs_remove(struct dentry *dentr
    dentry->d_name.name);
    } else
    simple_unlink(parent->d_inode, dentry);
    + if (!ret)
    + d_delete(dentry);
    + dput(dentry);
    }
    }
    mutex_unlock(&parent->d_inode->i_mutex);
    ---END---
    OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
    Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-24 19:53    [W:0.023 / U:187.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site