lkml.org 
[lkml]   [2006]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Add IDE mode support for SB600 SATA
    Tejun Heo wrote:
    > Conke Hu wrote:
    >> ATI SB600 SATA controller supports 4 modes: Legacy IDE, Native IDE,
    >> AHCI and RAID. Legacy/Native IDE mode is designed for compatibility
    >> with some old OS without AHCI driver but looses SATAII/AHCI features
    >> such as NCQ. This patch will make SB600 SATA run in AHCI mode even if
    >> it was set as IDE mode by system BIOS.
    [--snip--]
    > Other than that, Acked-by: Tejun Heo <htejun@gmail.com>

    At the second thought, I think this should be done in
    ahci_init_controller().

    * Unlike Jmicron's case, this doesn't affect PCI bus scan. Actually, it
    does change class code but that's not as disruptive as Jmicron's case
    and as long as ahci ignores class code, it doesn't really matter.
    Driver can be chosen by changing loading order - this is both plus and
    minus.

    * As Arjan pointed out, that unlock-modify-lock sequence should be done
    on resume too. ahci_init_controller() is the right place for such
    stuff. This chip is going into notebooks, right?

    --
    tejun
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-24 08:13    [W:0.024 / U:1.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site