Messages in this thread Patch in this message |  | | | Date | Thu, 23 Nov 2006 02:52:56 -0500 | | From | Mathieu Desnoyers <> | | Subject | [PATCH 2/5] DebugFS : coding style fixes |
| |
Minor coding style fixes along the way : 80 cols and a white space.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
* Greg KH (greg@kroah.com) wrote: > On Mon, Nov 20, 2006 at 01:18:38PM -0500, Mathieu Desnoyers wrote: > > Hi Greg, > > > > I just had to add inotify support to my LTTng consumer so I could inform it > > of the presence of new CPUs (for CPU hotplug). I noticed that no > > notification event was being sent when a debugfs file is created from within > > the kernel through debugfs_create. There are probably other notifications > > missing, but here is the patch adding the one I care about. Should it be added > > in libfs or in debugfs ? > > So does this fix the inotify issue? > > > A second problem I noticed is when a caller calls debugfs_create_file more than > > once : the result is that the debugfs_remove will fail. I guess the second call > > to debugfs_create_file increments the reference counts (there is not fix for > > this issue in my patch). > > > > Third problem : a failing call to debugfs_remove keeps the filesystem pinned. > > (fixed by calling simple_release_fs in the error path). > > > > The third problem : When a process is in a directory, the call to simple_rmdir > > will fail. Debugfs does not use its return value. I noticed that calling > > simple_unlink on a directory when simple_rmdir fails removes the directory that > > would otherwise be left there. I am not sure if this approach is correct > > through. > > > > This patch is against Linux 2.6.18. > > Care to split this into 4 different patches (you seem to have 4 issues > here), so that it's easier to see them, and it will follow the > 1-patch-per-issue rule? > > thanks, > > greg k-h > OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -54,7 +54,8 @@ inode->i_op = &simple_dir_inode_operations; inode->i_fop = &simple_dir_operations; - /* directory inodes start off with i_nlink == 2 (for "." entry) */ + /* directory inodes start off with i_nlink == 2 + * (for "." entry) */ inode->i_nlink++; break; } @@ -135,7 +136,7 @@ * block. A pointer to that is in the struct vfsmount that we * have around. */ - if (!parent ) { + if (!parent) { if (debugfs_mount && debugfs_mount->mnt_sb) { parent = debugfs_mount->mnt_sb->s_root; } |  |