![]() | ||||||||||
Messages in this thread |
On Thu, 23 Nov 2006 09:28:05 +0100
Sébastien Dugué <sebastien.dugue@bull.net> wrote:
> > > + if (notify->notify == (SIGEV_SIGNAL|SIGEV_THREAD_ID)) {
> > > + /*
> > > + * This reference will be dropped in really_put_req() when
> > > + * we're done with the request.
> > > + */
> > > + get_task_struct(target);
> > > + }
> >
> > It worries me that this function can save away a task_struct* without
> > having taken a reference against it.
> >
>
> OK. Does moving 'notify->target = target;' after the get_task_struct() will
> do, or am I missing something more subtle?
Well it's your code - you tell me ;)
It is unsafe (and rather pointless) to be saving the address of some structure
which can be freed at any time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| |||||||||
| Last update: 2006-11-23 08:45 [from the cache] ©2003-2008 | ||||||||||