lkml.org 
[lkml]   [2006]   [Nov]   [23]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 23 Nov 2006 21:42:48 +0000
FromAlan <>
SubjectRe: [PATCH 3/5] PCI : Add selected_regions funcs
On Thu, 23 Nov 2006 20:33:32 +0100
Ingo Oeser <ioe-lkml@rameria.de> wrote:

> Hi Hidetoshi Seto,
> 
> bitfields (and bitmask) should be unsigned and use machine word size,
> which is usually "long". So please pass them in "unsigned long" instead of "int".

There are a fixed number of BARs , besides which the interface already
uses int for the mask in pci_enable_device_bars() so the use of int is
fine and continues the existing API.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-23 21:39    [from the cache]
©2003-2008