Messages in this thread | | | Date | Thu, 23 Nov 2006 09:24:33 +0100 | From | Sébastien Dugué <> | Subject | Re: [PATCH -mm 3/4][AIO] - AIO completion signal notification |
| |
On Wed, 22 Nov 2006 02:22:15 -0800 Zach Brown <zach.brown@oracle.com> wrote:
> > OK, looking at this, there's something bothering me: io_submit_one() needs > > a pointer to the user iocb in order to push back the iocb->ki_key to userspace, > > as well as storing the user_iocb pointer into iocb->ki_obj. > > Why can't it continue to do what it does today? Both of those uses of > the user_iocb pointer involve fixed-width fields and don't need compat help.
Aah, right, thanks.
> > > So I think that some of the logic in io_submit_one() must be moved up to > > sys_io_submit(), including the aio_get_req() call. > > I don't see why that would be needed.
Not anymore, indeed.
Thanks,
Sébastien. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |